Extend test harness to support envconfig#2163
Draft
THardy98 wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for
TEMPORAL_TEST_ENV_CONFIG_SERVERenvironment variable.This environment variable gates whether the environment configuration feature (i.e.
envconfigcontrib package) should be used to load connection parameters used in the test environment.This allows for support of client/worker connections to arbitrary Temporal servers, allowing for testing against different server environments (i.e. local, staging, release, cloud, etc.).
Note: added the environment variable to gate against users already using
envconfig, we don't want to use their default env vars / config file unexpectedly against the test suite.Note:
packages/test/EXTERNAL_SERVER_TESTS.mdis a vibe-coded file that tracks files that do not use this change yet.Why?
Easily support testing against arbitrary server environments.
Part of: Run integration tests against cloud features#851
How was this tested:
adding a integration test...
Any docs updates needed?
Maybe?